Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrate): migration CLI should correctly migrate gtag options #6276

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Reported in #5832 (comment)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Updated test case

@Josh-Cena Josh-Cena added the pr: bug fix This PR fixes a bug in a past release. label Jan 6, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 6, 2022
@netlify
Copy link

netlify bot commented Jan 6, 2022

✔️ [V2]

🔨 Explore the source changes: 274b64f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61d6e13f854ef100086cb717

😎 Browse the preview: https://deploy-preview-6276--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 72
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-6276--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena merged commit 1d957d9 into main Jan 6, 2022
@Josh-Cena Josh-Cena deleted the jc/migration branch January 6, 2022 12:39
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Size Change: 0 B

Total Size: 673 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 41.6 kB
website/build/assets/css/styles.********.css 102 kB
website/build/assets/js/main.********.js 500 kB
website/build/index.html 29.6 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants