feat(v2): provide doc sidebar_label through sidebars.js #4500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
[pull] master from facebook:master
|
[V1] Deploy preview failure Built without sensitive environment variables with commit 3723ff0 https://app.netlify.com/sites/docusaurus-1/deploys/605ca3e5bc5a2e0007dabc71 |
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 3723ff0 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4500--docusaurus-2.netlify.app/ |
slorber
changed the title
slorber
requested changes
Mar 23, 2021
There was a problem hiding this comment.
Thanks @besemuna , the feature is working great and as I expected.
To be complete we need:
- doc
- unit tests (particularly showing that
sidebarLabelis used in priority overitem.label) - dogfooding on Docusaurus site itself
I suggest you refactor the i18n docs to declare the sidebar label to use through the sidebars.js file (using this new feature) instead of using frontmatter sidebar_label: xyz.
slorber
requested changes
Mar 24, 2021
website/versioned_docs/version-2.0.0-alpha.71/guides/docs/sidebar.md
Outdated
Show resolved
Hide resolved
website/versioned_docs/version-2.0.0-alpha.72/guides/docs/sidebar.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sébastien Lorber <[email protected]>
|
Thanks, that looks great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempt to fix #4314. These are the changes I've made
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)