fix(core): do not recreate ReactDOM Root, fix React warning on hot reload #10103
+62
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix React 18 hot reloading warning:
Initially reported here: #10099 (comment)
Note: this is not a React v18.3 warning, we can also have it in v18.2.
Note: Docusaurus does not have React Fast Refresh support, but we probably should have that. It doesn't look super easy to support 😅
Test Plan
CI + Tests
Local dev, hot reload works for both MD and JS files
Test links
https://deploy-preview-10103--docusaurus-2.netlify.app/