Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9880 #9943

Closed
wants to merge 2 commits into from
Closed

Fix #9880 #9943

wants to merge 2 commits into from

Conversation

femesq
Copy link

@femesq femesq commented Oct 28, 2020

Fix formatting error on webpack v5, as described here: #9880

Specifically in this link, on the item that says:

Stats json errors and warnings no longer contain strings but objects with information splitted into properties.
MIGRATION: Access the information on the properties. i. e. message

Fix formatting error on webpack v5, as described here: facebook#9880

Specifically in [this link](https://webpack.js.org/blog/2020-10-10-webpack-5-release/#minor-changes), on the item that says:

Stats json errors and warnings no longer contain strings but objects with information splitted into properties.
MIGRATION: Access the information on the properties. i. e. message
@moonjoungyoung
Copy link

Any update?

Copy link

@vagrantsn vagrantsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works after applying the fix I suggested! 🚀

packages/react-dev-utils/formatWebpackMessages.js Outdated Show resolved Hide resolved
@mrmckeb mrmckeb added this to the 4.0.3 milestone Feb 5, 2021
Copy link

@vagrantsn vagrantsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@vagrantsn vagrantsn mentioned this pull request Feb 10, 2021
25 tasks
@iansu iansu modified the milestones: 4.0.3, 4.0.4 Feb 22, 2021
@utterly-calm
Copy link

It's taking too much to fix this issue. People are suffering in April 2020 as well. Please merge it. Any plans?

@mrmckeb
Copy link
Contributor

mrmckeb commented May 30, 2021

Thanks for the patience. This hasn't been a priority for us as we don't support Webpack 5 yet, however I understand this is a non-breaking change for existing users and we'll get this out for in the next release.

Edit: This is one of three similar PRs, we'll get one of these out in the next release - but I'll chat to the team about which approach is best for us.

See: #10098 and #10121.

@mrmckeb
Copy link
Contributor

mrmckeb commented May 30, 2021

Hi @femesq, thanks for your time on this. After a discussion with @raix, we're closing this in favour of #10121 and plan to have this out in the next minor release. Please let us know if you have any issues after that time!

@mrmckeb mrmckeb closed this May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants