Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in webpack.config.dev.js comments #777

Merged
merged 2 commits into from
Sep 30, 2016

Conversation

sebastiandedeyne
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Sep 27, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

Can you please fix this in prod config as well? Thank you!

@ghost
Copy link

ghost commented Sep 27, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed label Sep 27, 2016
@sebastiandedeyne
Copy link
Contributor Author

Done!

@gaearon
Copy link
Contributor

gaearon commented Sep 27, 2016

Would it be too much to ask you to look through all other files and hunt for typos? I'm pretty sure I made a few more but I can't remember where. No worries if it's too much, just let me know.

@sebastiandedeyne
Copy link
Contributor Author

Sure :) I'll try to go through it tomorrow!

On Tuesday, 27 September 2016, Dan Abramov [email protected] wrote:

Would it be too much to ask you to look through all other files and hunt
for typos? I'm pretty sure I made a few more but I can't remember where. No
worries if it's too much, just let me know.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#777 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABfR957QGB5VgIpfLYAPA2dgThv7wwgLks5quQfdgaJpZM4KHg6p
.

@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2016

Going to get this in for now but I’d still appreciate a complete review. 😄

@gaearon gaearon added this to the 0.7.0 milestone Sep 30, 2016
@gaearon gaearon merged commit 0ad930e into facebook:master Sep 30, 2016
@existentialism existentialism mentioned this pull request Oct 1, 2016
kitze added a commit to kitze/custom-react-scripts that referenced this pull request Oct 3, 2016
…react-app

# By Dan Abramov (5) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  docs(readme): peer dependencies applied (facebook#818)
  Fix typos on ISSUE_TEMPLATE.md (facebook#817)
  Add explicit linebreaks (facebook#813)
  Fix typo (facebook#810)
  Fix some typos (facebook#809)
  Beaufity output of eject.js script (facebook#769)
  Define process.env as object (facebook#807)
  Typo fix in webpack.config.dev.js comments (facebook#777)
  Add Netlify to deploy instructions
  Fix usage example to match [email protected] API
  Relaxed eslint rule no-unused-expressions (facebook#724)
  Fix the doc
  Publish
  Add 0.6.1 changelog
  Moved Babel and ESLint config to package.json after ejecting (facebook#773)

Conflicts:
	packages/react-scripts/package.json
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Typo fix in webpack.config.dev.js comments

* Typo fix in webpack.config.prod.js comments
maltestenzel pushed a commit to maltestenzel/custom-react-scripts that referenced this pull request Mar 7, 2018
…react-app

# By Dan Abramov (5) and others
# Via Dan Abramov
* 'master' of https://github.com/facebookincubator/create-react-app:
  docs(readme): peer dependencies applied (facebook#818)
  Fix typos on ISSUE_TEMPLATE.md (facebook#817)
  Add explicit linebreaks (facebook#813)
  Fix typo (facebook#810)
  Fix some typos (facebook#809)
  Beaufity output of eject.js script (facebook#769)
  Define process.env as object (facebook#807)
  Typo fix in webpack.config.dev.js comments (facebook#777)
  Add Netlify to deploy instructions
  Fix usage example to match [email protected] API
  Relaxed eslint rule no-unused-expressions (facebook#724)
  Fix the doc
  Publish
  Add 0.6.1 changelog
  Moved Babel and ESLint config to package.json after ejecting (facebook#773)

Conflicts:
	packages/react-scripts/package.json
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants