Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup-after-each is no longer necessary! #7620

Merged
merged 2 commits into from
Sep 2, 2019
Merged

cleanup-after-each is no longer necessary! #7620

merged 2 commits into from
Sep 2, 2019

Conversation

iHmD
Copy link
Contributor

@iHmD iHmD commented Aug 31, 2019

No description provided.

iHmD added 2 commits August 31, 2019 12:31
cleanup is called now by default after each test if the testing framework supports the afterEach global!
cleanup-after-each is no longer necessary!
@iHmD iHmD requested review from amyrlam and iansu as code owners August 31, 2019 12:37
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ianschmitz ianschmitz added this to the 3.1.2 milestone Sep 2, 2019
@ianschmitz ianschmitz merged commit 6dec056 into facebook:master Sep 2, 2019
@lock lock bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants