Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ForkTsCheckerWebpackPlugin with async when CI env is used #6209

Closed
wants to merge 1 commit into from
Closed

Run ForkTsCheckerWebpackPlugin with async when CI env is used #6209

wants to merge 1 commit into from

Conversation

insidewhy
Copy link

@insidewhy insidewhy commented Jan 15, 2019

See #5820

To briefly summarise: ForkTsCheckerWebpackPlugin is run with async: false due to screen clearing issues hiding console errors, the unfortunate side-effect being that the recompilations take several seconds instead of less than 300ms.

When the CI environment variable is set the screen is not cleared so the "errors being hidden" issue cannot be present. In that case async can be set to true to have much faster compilation times. Then users who wish to use typescript and would prefer to have their development experience be drastically faster and won't mind the screen not being cleared can simply set CI in their package.json.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ianschmitz
Copy link
Contributor

This sounds like a dupe of #5903?

@insidewhy
Copy link
Author

@ianschmitz Cool #5903 looks like a better way to do this, I may as well close this.

@insidewhy insidewhy closed this Jan 15, 2019
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants