Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix —info clipboard usage, envinfo no longer supports clipboard option #5911

Closed
wants to merge 1 commit into from

Conversation

tabrindle
Copy link
Contributor

In an effort to fix --info on windows, a previous PR removed the auto copy to clipboard feature.

This adds it back using the same library envinfo previously used.

@iansu
Copy link
Contributor

iansu commented Nov 27, 2018

Will this work on Windows now?

@tabrindle
Copy link
Contributor Author

It should as it is installed normally, and clipboardy does support windows - although I don't have a good way to confirm this right now.

@Timer
Copy link
Contributor

Timer commented Nov 27, 2018

I think we'd rather just let this print out for the time being. There's been too many issues.

@iansu
Copy link
Contributor

iansu commented Nov 27, 2018

I kind of agree. Especially if this means we're now going to be installing a package with native extensions. Given how often that stuff breaks, especially around new Node releases, it seems risky.

@tabrindle
Copy link
Contributor Author

Fine with me, this is after all why I removed it from my library.

@tabrindle tabrindle closed this Nov 27, 2018
@Timer
Copy link
Contributor

Timer commented Nov 28, 2018

Thanks for always being on top of these issues, @tabrindle!

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants