Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flow instructions #567

Merged
merged 1 commit into from
Sep 3, 2016
Merged

Update Flow instructions #567

merged 1 commit into from
Sep 3, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Sep 3, 2016

Flow has recently changed its defaults to better fit Create React App.
The only remaining issue is the one with fbjs so I left it in the workaround doc.

Great work Flow team!

@ghost ghost added the CLA Signed label Sep 3, 2016
@gaearon gaearon merged commit 4534fd0 into master Sep 3, 2016
@gaearon gaearon deleted the gaearon-patch-1 branch September 3, 2016 19:35
@gaearon gaearon mentioned this pull request Sep 3, 2016
Closed
@denkristoffer
Copy link
Contributor

Running the latest Flow just built from master my config still needs

[ignore]
<PROJECT_ROOT>/node_modules/fbjs/.*
<PROJECT_ROOT>/node_modules/react/node_modules/fbjs/.*

[options]
module.name_mapper='^\(.*\)\.css$' -> 'react-scripts/config/flow/css'

@gaearon
Copy link
Contributor Author

gaearon commented Sep 4, 2016

What error do you get if you remove the CSS mapping? Can you publish a project reproducing this?

@denkristoffer
Copy link
Contributor

I'm getting errors like ./App.css. Required module not found. I'll see if I can recreate the problem in a new project.

@gaearon
Copy link
Contributor Author

gaearon commented Sep 5, 2016

If you can please file an issue and we'll take a look. Thanks.

stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
@gaearon
Update Flow instructions (facebook#567)
2e4dba8
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@gaearon @feiqitian
Update Flow instructions (facebook#567)
2d4048e
@ubershmekel ubershmekel mentioned this pull request Jun 23, 2017
Closed
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaearon @denkristoffer