Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #5400

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Tweaks #5400

merged 3 commits into from
Oct 11, 2018

Conversation

amyrlam
Copy link
Contributor

@amyrlam amyrlam commented Oct 11, 2018

Review commit by commit, added some questions by commit.

  • Make Getting Started consistent
  • Order docs in footer
    • Rename to match page "About The Docs"
    • Question 🤔: These seem redundant, consider just "Getting Started"? Add more links?
  • Edits to Getting Started
    • Copy edits for consistency
    • Remove <br>'s for readability
    • Question 🤔: Should all headers be Title Case? I see Creating an App but Installing A Dependency. I tend to use https://titlecaseconverter.com/, thoughts?

Rename to match page "About The Docs"

These seem redundant, consider just "Getting Started"? Add more links?
- Copy edits for consistency
- Remove <br>'s for readability

Should all headers be Title Case? I see `Creating an App` but `Installing A Dependency`. I tend to use https://titlecaseconverter.com/, thoughts?
@selbekk
Copy link
Contributor

selbekk commented Oct 11, 2018

Great job! 💃

@selbekk selbekk merged commit 9d79482 into facebook:docusaurus Oct 11, 2018
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants