Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file size report after build (#5333) #5335

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Fix file size report after build (#5333) #5335

merged 1 commit into from
Oct 6, 2018

Commits on Oct 6, 2018

  1. Fix file size report after build 

    Fixes facebook#5333

printFileSizesAfterBuild calls canReadAsset with an object containing
the file name while measureFileSizesBeforeBuild calls it with just the
name. When canReadAsset only receives the name it returns false since
accessing the `name` property results in undefined.

This commit fixes that by having canReadAssset instead expect only the
file name and making printFileSizesAfterBuild just like
measureFileSizesBeforeBuild only provide the name as argument.
    @OskarPersson
    OskarPersson committed Oct 6, 2018
    Configuration menu
    Copy the full SHA
    9c9bf12 View commit details
    Browse the repository at this point in the history