Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GENERATE_SOURCEMAP env not working for css sourcemap #5246

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix GENERATE_SOURCEMAP env not working for css sourcemap #5246

merged 1 commit into from
Oct 2, 2018

Conversation

crux153
Copy link
Contributor

@crux153 crux153 commented Oct 2, 2018

This fixes GENERATE_SOURCEMAP env option not being respected for css sourcemap, by checking its presence before passing sourcemap options to OptimizeCSSAssetsPlugin.

It can be simply tested by running react-scripts build with and without GENERATE_SOURCEMAP=false, and see if any sourcemaps are being created under build/static/css

@Timer Timer added this to the 2.0.4 milestone Oct 2, 2018
@Timer
Copy link
Contributor

Timer commented Oct 2, 2018

Thanks! For now you can just remove the files safely.

@Timer Timer merged commit d624f25 into facebook:master Oct 2, 2018
@Timer Timer mentioned this pull request Oct 3, 2018
Closed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@crux153 @Timer
Fix GENERATE_SOURCEMAP env not working for css (facebook#5246)
2de3645
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@crux153 @Timer @facebook-github-bot