Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute paths on eject #5214

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fix absolute paths on eject #5214

merged 1 commit into from
Oct 1, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 1, 2018

This fixes absolute paths that were introduced when ejecting in #5136.
This does break PnP on eject though. I asked @arcanis to look into fixing this.

The proper fix would be to actually generate a jest.config.js after eject, and keep them as resolve().

@gaearon gaearon added this to the 2.0 milestone Oct 1, 2018
@gaearon gaearon merged commit 45e6217 into master Oct 1, 2018
@Timer Timer deleted the absolute-ej branch October 1, 2018 23:50
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants