Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions to README on how to customize Bootstrap with Sass #5211

Merged
merged 4 commits into from
Oct 1, 2018
Merged

Adds instructions to README on how to customize Bootstrap with Sass #5211

merged 4 commits into from
Oct 1, 2018

Conversation

mslooten
Copy link
Contributor

@mslooten mslooten commented Oct 1, 2018

As discussed in #5154 there's an easier way to customize Bootstrap in React using Sass (starting from [email protected]). I've changed the section in the docs to make use of Sass (and tested the code of course). I'm hoping the level of detail is good here. I thought about going deeper but I felt it wasn't needed.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@mslooten mslooten changed the title Adds instructions to create a Bootstrap theme with Sass Adds instructions README to customize Bootstrap with Sass Oct 1, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mslooten mslooten changed the title Adds instructions README to customize Bootstrap with Sass Adds instructions to README on how to customize Bootstrap with Sass Oct 1, 2018
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 2.0.x milestone Oct 1, 2018
@gaearon
Copy link
Contributor

gaearon commented Oct 1, 2018

looks good to me, @Timer want to tweak anything?

@Timer
Copy link
Contributor

Timer commented Oct 1, 2018

Tweaked it, take a peek?

@Timer Timer modified the milestones: 2.0.x, 2.0 Oct 1, 2018
@gaearon gaearon merged commit b539b64 into facebook:master Oct 1, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 29, 2018
…acebook#5211)

* Adds instructions to create a Bootstrap theme with Sass

* Update README.md

* Update README.md

* Update README.md
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
@mslooten mslooten deleted the bootstrap-sass branch July 22, 2020 10:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants