Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] remove babelrc dependency for kitchensink test #5098

Merged
merged 2 commits into from
Sep 26, 2018
Merged

[internal] remove babelrc dependency for kitchensink test #5098

merged 2 commits into from
Sep 26, 2018

Conversation

bugzpodder
Copy link

@bugzpodder bugzpodder commented Sep 26, 2018

@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

Awesome, thanks for working on fixing this. 💯

@bugzpodder bugzpodder changed the title add kitchensink-eject to local-test [internal] remove babelrc dependency for kitchensink test Sep 26, 2018
@Timer
Copy link
Contributor

Timer commented Sep 26, 2018

Can you look into fixing the local docker tests for kitchensink?

@bugzpodder
Copy link
Author

You mean running yarn e2e:docker locally? Sure. It hanged for me when I tried it so I had to kick off the CI runs but yeah I can check it out.

@Timer Timer added this to the 2.0.0 milestone Sep 26, 2018
@Timer Timer merged commit 63398bd into facebook:next Sep 26, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* add kitchensink-eject to local-test

* add jest transform

Closes facebook#5095
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants