Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to CI #4193

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Minor fixes to CI #4193

merged 1 commit into from
Mar 21, 2018

Conversation

ro-savage
Copy link
Contributor

@ro-savage ro-savage commented Mar 21, 2018

This fixes some CI issue that I encountered, when trying to run CI locally (and on the CI servers).

This does not fix everything, but gets the CI closer to working correctly.

  • Remove cache clean as it is unneeded in npm@5 and throws an error
  • Fix issues with linting that fails CI

@Timer Timer added this to the 2.0.0 milestone Mar 21, 2018
@Timer Timer merged commit b2fd8db into facebook:next Mar 21, 2018
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Mar 22, 2018
* next:
  Fix typos in example monorepo documentation. (facebook#4164)
  Minor fixes to CI (facebook#4193)
  Change no-unused-vars 'args' from none to all to show warning on destructured objects
  Bump babel-related deps (facebook#4159)
  Remove ref to non free resource (facebook#4160)
NMinhNguyen added a commit to NMinhNguyen/create-react-app that referenced this pull request Mar 25, 2018
iansu pushed a commit that referenced this pull request Mar 26, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants