Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia link change #4126

Closed
wants to merge 12 commits into from
Closed

wikipedia link change #4126

wants to merge 12 commits into from

Conversation

jfdnc
Copy link

@jfdnc jfdnc commented Mar 8, 2018

Current 'polyfills' link directs to disambiguation page with multiple definitions of the term. The context in README.md refers to the specific type of polyfill that the new link references.

https://en.wikipedia.org/wiki/Polyfill -> https://en.wikipedia.org/wiki/Polyfill_(programming)

bondz and others added 11 commits January 18, 2018 11:55
Update User Guide's README.md to include `json` and `css`
files in the command to format the entire project for the first time
with prettier, that it's consistent with the `lint-staged` command.
)"

This reverts commit bab2c29.

I meant to apply it to `next` instead.
Current 'polyfills' link directs to disambiguation page with multiple definitions of the term. The context in README.md refers to the specific type of polyfill that the new link references. 

https://en.wikipedia.org/wiki/Polyfill -> https://en.wikipedia.org/wiki/Polyfill_(programming)
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu
Copy link
Contributor

iansu commented Mar 14, 2018

Please change the base branch of this PR to next instead of master.

@Timer
Copy link
Contributor

Timer commented Mar 26, 2018

Ping @jfdnc.

@jfdnc jfdnc changed the base branch from master to next March 26, 2018 14:52
@jfdnc
Copy link
Author

jfdnc commented Mar 26, 2018

Branch changed, thanks for the ping @Timer

@Timer
Copy link
Contributor

Timer commented Mar 26, 2018

Hmm, I think you're going to need to revert other commits that came over from the branch switch (look at the PR changes).
Maybe it'd be easier to re-edit this in a new PR?

@jfdnc jfdnc closed this Mar 26, 2018
@jfdnc jfdnc deleted the patch-1 branch March 26, 2018 20:58
@Timer
Copy link
Contributor

Timer commented Mar 27, 2018

Did you want to open a new PR?

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants