Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix floating caret position incorrect while scrolling overlay #4024

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Fix floating caret position incorrect while scrolling overlay #4024

merged 1 commit into from
Mar 27, 2018

Conversation

jihchi
Copy link
Contributor

@jihchi jihchi commented Feb 14, 2018

As screenshots, notice the position of "caret" symbol.

Before

caret_before

After

caret_after

@iansu
Copy link
Contributor

iansu commented Feb 20, 2018

I haven't noticed this bug before. I'm curious when it might have been introduced and what browsers it affects. What browser are you using in the screenshots above?

@gaearon gaearon added this to the 2.0.0 milestone Feb 20, 2018
@jihchi
Copy link
Contributor Author

jihchi commented Feb 21, 2018

@iansu Chrome Version 64.0.3282.167 (Official Build) (64-bit)

screenshot_2018-02-21_11-12-01_6alob

I've tried following browsers have same issue:

  • Chrome Canary Version 66.0.3350.0 (Official Build) canary (64-bit)
  • Safari Version 11.0.3 (13604.5.6)

@jihchi
Copy link
Contributor Author

jihchi commented Feb 21, 2018 •
edited
Loading

I've created a demo project: https://github.com/jihchi/create-react-app-4024

@Timer
Copy link
Contributor

Timer commented Mar 27, 2018

Looks fine to me. Thanks!

@Timer Timer merged commit da518d2 into facebook:next Mar 27, 2018
@jihchi jihchi deleted the fix_floating_caret_in_error_overlay branch March 27, 2018 04:01
tvalentius added a commit to tvalentius/create-react-app that referenced this pull request Mar 27, 2018
@tvalentius
Merge pull request #20 from facebook/next
7c54a93 
Fix floating caret position incorrect while scrolling overlay (facebook#4024)
@renovate renovate bot mentioned this pull request Apr 9, 2018
Merged
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: bug fix
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jihchi @iansu @Timer @gaearon @facebook-github-bot