Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotenv to 5.0.0 #4009

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Update dotenv to 5.0.0 #4009

merged 1 commit into from
Feb 10, 2018

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Feb 9, 2018

Update dotenv to address the bug in #4002

This should probably also be backported to 1.x.

@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2018

Rebase please?

@iansu
Copy link
Contributor Author

iansu commented Feb 10, 2018

Should be ready to go now.

@iansu iansu merged commit 43fbf0f into facebook:next Feb 10, 2018
@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2018

Did 5.x have breaking changes that impact our users?

@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2018

Or is that this fix itself the change?

@gaearon gaearon added this to the 2.0.0 milestone Feb 10, 2018
@iansu
Copy link
Contributor Author

iansu commented Feb 10, 2018

I believe this bug fix is the primary change. Everything else appears to be documentation improvements, error message improvements and things like that.

tvalentius added a commit to tvalentius/create-react-app that referenced this pull request Feb 11, 2018
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
@iansu iansu deleted the dotenv-update branch October 18, 2019 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants