Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the E2E script #3888

Merged
merged 2 commits into from
Jan 21, 2018
Merged

Fix the E2E script #3888

merged 2 commits into from
Jan 21, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 21, 2018

It needed this commit because our git integration had a race condition. I fixed it in #3877 so now the commit ends up empty and fails. We can remove this now.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 21, 2018

Umm this breaks Windows (??)

@gaearon
Copy link
Contributor Author

gaearon commented Jan 21, 2018

This explains it:

*** Please tell me who you are.
Run
  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'appveyor@APPVYR-WIN.(none)')

Git exists on the system so it lets us git init but doesn't let us git commit.

@gaearon gaearon merged commit d49ffde into next Jan 21, 2018
@Timer Timer deleted the gaearon-patch-3 branch January 22, 2018 02:53
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
@gaearon @akstuhl
Fix the E2E script (facebook#3888)
3458262 
* Fix the E2E script

* Delete .git if committing failed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
@gaearon
Fix the E2E script (facebook#3888)
f869937 
* Fix the E2E script

* Delete .git if committing failed
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaearon @facebook-github-bot