Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svg rendering for error example #3825

Merged
merged 2 commits into from
Jan 17, 2018

Conversation

marionebl
Copy link
Contributor

@marionebl marionebl commented Jan 17, 2018

  • Add screencast:error run-script
  • Replace png error example with static SVG rendering
  • Match style of Getting started screencast

@gaearon gaearon added this to the 2.0.0 milestone Jan 17, 2018
@gaearon gaearon merged commit a3d002e into facebook:next Jan 17, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

Thanks! How hard would it be to do the test runner with a filtering example?

@marionebl
Copy link
Contributor Author

Should be doable, what pattern do you have in mind?

@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

Just "app" maybe

@marionebl
Copy link
Contributor Author

@gaearon
Copy link
Contributor

gaearon commented Jan 17, 2018

I think it would look more impressive if there were more tests 😄 Can we use some open source project? e.g. Redux examples use CRA scripts.

Another minor thing is that Jest removed autocomplete in 22 because of some issues. So let's wait until we release 2.x alpha and then we can record the more recent behavior.

akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
* Add svg rendering for error example

* Use static svg error example
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants