Allowing "file:<path>" --scripts-version values

[GreenGremlin]

This change is useful for testing local changes to scripts packages before committing them.

e. g.

create-react-app my-app --scripts-version=file:./create-react-app/packages/react-scripts
# or
create-react-app my-app --scripts-version=file:./path/to/custom/scripts-package

I verified these changes by running npm link inside the create-react-app package and then running create-react-app my-app --scripts-version=file:./create-react-app/packages/react-scripts.

[gaearon]

OK. I can't promise we won't break this in the future, but doesn't hurt to get it in.

[GreenGremlin]

Understandable, thanks!

[gaearon]

This is out! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0

[leepowelldev]

Trying to get this to work. I've gone into my custom 'react-scripts' directory (after forking this repo and cloning it - nothing edited) and ran npm link and then ran create-react-app myapp --scripts-version=file:/path/to/create-react-app/packages/react-scripts and it all sets up ok. But it fails to compile when started with the following error:

Failed to compile.

./src/index.js
Module build failed: Error: Plugin/Preset files are not allowed to export objects, only functions.
    at Array.map (<anonymous>)

Any ideas what I'm missing?

[GreenGremlin]

@leepowellcouk instead of npm link, I'd suggest just running npm install, but that shouldn't matter. What version of node/npm are you using?

[gaearon]

I'd note our local development workflow might be broken right now due to recent changes. If you file a separate issue for that, it would be nice. We had a yarn create-react-app local command for that but it might have also broken. I think I know what needs to be fixed but haven't done so yet.

[leepowelldev]

Looked like it was a corrupt react-scripts for me, for some reason a couple of deps had failed. Cleaned it all down, started again and it works great. Thanks for all the hard work that goes into this tooling!