Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve eject message #3416

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Improve eject message #3416

merged 2 commits into from
Nov 7, 2017

Conversation

xjlim
Copy link
Contributor

@xjlim xjlim commented Nov 6, 2017

Fix #2797, override #2838.

image

@Timer
Copy link
Contributor

Timer commented Nov 7, 2017

Will this work in Windows if the user strictly has Git installed with nothing added to PATH?

@Timer Timer added this to the 1.0.x milestone Nov 7, 2017
@xjlim
Copy link
Contributor Author

xjlim commented Nov 7, 2017

I believe it comes with git bash. Depending on the installation of git, if those unix tools get added to the PATH then it should work.
image

@TryingToImprove
Copy link

I have GIT in my PATH but

git status --porcelain | awk

returns:

'awk' is not recognized as an internal or external command,
operable program or batch file.

@xjlim
Copy link
Contributor Author

xjlim commented Nov 7, 2017

made it work without awk.

@Timer while testing, I realize that some scripts for development such as create-react-app here is not cross platform. Was that intentional?

@Timer
Copy link
Contributor

Timer commented Nov 7, 2017

We don't mind much about the local scripts, but I believe there is a pull request transitioning these to use Node so that they are cross platform.

@Timer
Copy link
Contributor

Timer commented Nov 7, 2017

I trust you that this still works.

Thanks!

@Timer Timer merged commit 4bec877 into facebook:master Nov 7, 2017
@Timer Timer mentioned this pull request Nov 7, 2017
Closed
@xjlim
Copy link
Contributor Author

xjlim commented Nov 7, 2017

Tested both on OSX and Windows. It works as describe in the screenshot above and now it handles filenames with spaces.

placenamehere pushed a commit to automatastudios/create-react-app that referenced this pull request Nov 30, 2017
@xjlim @placenamehere
Improve eject message (facebook#3416)
15c014e 
* improve eject message

* cross os implementation
@gaearon gaearon mentioned this pull request Jan 15, 2018
Merged
@dependencies dependencies bot mentioned this pull request Jan 15, 2018
Merged
This was referenced Feb 2, 2018
Open
Closed
Closed
Closed
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@xjlim
Improve eject message (facebook#3416)
f559382 
* improve eject message

* cross os implementation
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
@xjlim @Timer
Improve eject message (facebook#3416)
b189608 
* improve eject message

* cross os implementation
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@xjlim @Timer @TryingToImprove @facebook-github-bot