Fix error overlay 'Object.assign' issue in IE #3043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Sep 1, 2017
| @@ -174,7 +174,9 @@ class StackFrame extends Component { | |||
| onClick={canOpenInEditor ? this.openInEditor : null} | |||
| style={canOpenInEditor ? codeAnchorStyle : null} | |||
| > | |||
| <CodeBlock {...codeBlockProps} /> | |||
| {// Use JS instead of JSX spread attributes to avoid Object.assign | |||
There was a problem hiding this comment.
That's unfortunate. Are you sure this is really an issue? I had an impression that JSX puts extends helper in either case.
There was a problem hiding this comment.
Yes. We have enabled useBuiltIns flag for babel-plugin-transform-react-jsx as well.
https://github.com/facebookincubator/create-react-app/blob/master/packages/babel-preset-react-app/index.js#L27
|
I think this is too fragile. We'll mess it up again. Let's just import polyfills first. |
|
I feel the same. I'll close this and create another with polyfills first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3034
Babel React JSX transform plugin is also use
Object.assignfor spread attributes. SoReact.createElementhas been used here to avoidObject.assign