sw-precache: don't fallback if URL starts with /api #3029
Conversation
|
Without this PR, whole section Integrating with an API Backend is irrelevant for production builds. Moreover examples in tutorials probably won't work in version v0.10+ |
|
Hello! I'm a bot that helps facilitate testing pull requests. Your pull request (commit 74b9dc4) has been released on npm for testing purposes. npm i [email protected]
# or
yarn add [email protected]
# or
create-react-app [email protected] folder/Note that the package has not been reviewed or vetted by the maintainers. Only install it at your own risk! Thanks for your contribution! |
|
To explain further: Proxy feature works in development environment but on production any requests that are not cached by service worker will resolve to index.html anyway. So proxy feature doesn't make sense as in production you have to place API on other origin anyway. There should be at least one exception for service worker fallback and Side note: There is a PR #3419 which aims to disable navigateFallback option completely. |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. |
|
This pull request has been automatically closed because it has not had any recent activity. The conversation will be locked in 7 days unless the pull request is reopened. Thank you for your contribution. |
No description provided.