Disable service workers until issues fixed #2995
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
|
||
| ReactDOM.render(<App />, document.getElementById('root')); | ||
| registerServiceWorker(); | ||
| // Consider enabling service workers for caching and offline pages by uncommenting the following line |
There was a problem hiding this comment.
maybe add a link to https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#making-a-progressive-web-app so the user knows what they will get into?
|
Thanks for the PR, in the next branch service workers are disabled by default now: |
|
Sorry, wrong pull. |
See the problems in this thread.
#2398
There are more than 83 comments there to date. Many are confused by service workers and their side effects. We should find the time to fix service workers. Until then, keeping service workers in their current state may deteriorate trust in service workers and create-react-app more than it helps creating progressive web apps.