Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put react-scripts in dependencies, not devDependencies #2657

Merged
merged 3 commits into from
Jun 28, 2017

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jun 28, 2017

The distinction doesn't fully make sense in React world because you need both types to bundle the app, and neither on the server. It also created problems for folks who run build on deployment. It is also inconsistent (for example promise polyfill is technically a runtime dependency but was treated as a build one). Fixes #2655 as well.

@gaearon
Copy link
Contributor Author

gaearon commented Jun 28, 2017

Pretty sure this works.

@gaearon gaearon merged commit 9559ba4 into facebook:master Jun 28, 2017
@gaearon gaearon added this to the 1.0.8 milestone Jun 28, 2017
@gaearon gaearon mentioned this pull request Jun 28, 2017
zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 29, 2017
* upstream/master: (55 commits)
  Fix minor typo (facebook#2679)
  Bootstrap with Yarn when available (facebook#2673)
  Add more info about apache client side routing (facebook#2666)
  Test Node 8 on Travis (facebook#2659)
  Add json and css to lint-staged in template README (facebook#2671)
  Add a note about fixed vulnerability in 1.0.8
  Publish
  Changelog for 1.0.8 (facebook#2664)
  Reformat source code with Prettier 1.5.2
  Update Prettier to v1 (facebook#2465)
  Update ISSUE_TEMPLATE.md
  Local testing docker links (facebook#2662)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  ...

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
* Put react-scripts in dependencies, not devDependencies

* Sort dependencies on eject

* Remove CI check
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
* Put react-scripts in dependencies, not devDependencies

* Sort dependencies on eject

* Remove CI check
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
* Put react-scripts in dependencies, not devDependencies

* Sort dependencies on eject

* Remove CI check
bjoernricks added a commit to greenbone/gsa that referenced this pull request Oct 26, 2017
src/html/classic/ng/yarn.lock: Update react-script (from create-react-app) to
latest release (1.0.10) and put it into dependenciesi (details:
facebook/create-react-app#2657). Remove other
devdependencies which aren't necessary anymore. They have been added due to a
bug in eslint for validating in external editors.

git-svn-id: svn+ssh://scm.wald.intevation.org/openvas/trunk/gsa@29027 423fd1db-d629-0410-8442-d21db03e70f4
@bondz bondz mentioned this pull request Apr 16, 2018
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants