Fix sourcemap directory organizing on Windows (#2456) #2610
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Do you know if there's a chrome bug report open about this? |
|
So apparently source-maps are supposed to refer to URLs (mozilla/source-map#91 and source map spec), which is why the backslash doesn't work. I don't think this is a Chrome-specific thing. I've updated the comments. |
|
Looks good, thanks! |
…ok#2610) * Fix sourcemap directory organizing on Windows * Update comments
* Fix sourcemap directory organizing on Windows * Update comments
…ok#2610) * Fix sourcemap directory organizing on Windows * Update comments
Chrome devtools doesn't recognize Windows file paths with backslashes. This is a naive fix, replacing backslashes with forward slashes. I tried looking for a more generalized
pathfunction that did this, but didn't find any.Before:
After:
Fixes #2456.