Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial settings for editorconfig #154

Closed
wants to merge 1 commit into from

Conversation

chocnut
Copy link
Contributor

@chocnut chocnut commented Jul 24, 2016

No description provided.

@ghost
Copy link

ghost commented Jul 24, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ghost
Copy link

ghost commented Jul 24, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Jul 24, 2016

Hi, thanks for the PR! I think we won’t go with this. We’re not actually opinionated about the code style, and this is just another configuration file, which we want to avoid. If the user cares about having an editorconfig, we think they will add it.

@gaearon gaearon closed this Jul 24, 2016
@ArmorDarks
Copy link

@gaearon I think that was intended to enforce code styling in create-react-app, not in user's codebase. And considering this, I was surprised this wasn't merged.

@Timer
Copy link
Contributor

Timer commented Mar 19, 2017

That might have been the case (oops), however, we're using prettier now which enforces code style in our code base.

@ArmorDarks
Copy link

@Timer Prettier works only for JS. .editorconfig scope is much wider.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants