Move tailwindcss to optional peer dependencies #12046
Conversation
|
Hi @MartijnHols! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
MartijnHols
changed the title
MartijnHols
force-pushed
the
fix/12044-dont-install-tailwindcss
branch
from
21dcf73
to
0b256f2
Compare
Fixes facebook#12044 Installing tailwindcss comes with a bunch of junk most people don't need, and at least prettier-plugin-tailwindcss but possibly more subdependecies are unlicensed which makes usage troublesome.
MartijnHols
force-pushed
the
fix/12044-dont-install-tailwindcss
branch
from
0b256f2
to
763745b
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Would be great to see this merged, such that issues with tailwind don't break CRA. See recent issue
|
I think Tailwind CSS should have a page in the docs with this change, e.g. https://create-react-app.dev/docs/adding-a-sass-stylesheet/ |
Fixes #12044
Installing tailwindcss comes with a bunch of junk most people don't need, and at least prettier-plugin-tailwindcss but possibly more subdependecies are unlicensed which makes usage troublesome.