Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cached lockfile #11706

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Dec 2, 2021

To go along with #11474, we no longer need the cached lockfile after unpinning all the dependencies.

This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.

To go along with facebook#11474, we no longer need the cached lockfile after unpinning all the dependencies.

This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.
@iansu iansu added this to the 5.0 milestone Dec 2, 2021
@iansu iansu merged commit 69321b0 into facebook:main Dec 2, 2021
@iansu
Copy link
Contributor

iansu commented Dec 2, 2021

Thanks!

@lukekarrys lukekarrys deleted the lk/rm-cached-lockfile branch December 3, 2021 00:15
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants