Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jest and related packages from 26.6.0 to 27.1.0 #11338

Merged
merged 9 commits into from
Sep 22, 2021

Conversation

krreet
Copy link
Contributor

@krreet krreet commented Aug 28, 2021

Closes #10747. Fixes #9993.

Tested and working fine with jest 27.1.0

yarn test , yarn start , yarn build

cratests
buildcra

included changes from #10748

@facebook-github-bot
Copy link

Hi @krreet!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@krreet krreet mentioned this pull request Aug 28, 2021
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@krreet
Copy link
Contributor Author

krreet commented Sep 1, 2021

@iansu Due to npm ci added in #11304 , now we have to also commit the package-lock.json . Now the checks should pass.
npm i
image

npm test
image

Copy link

@sauldeleon sauldeleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!!

@krreet krreet requested a review from petetnt September 3, 2021 13:41
@iansu
Copy link
Contributor

iansu commented Sep 16, 2021

This looks great. Can you revert the changes to packages/create-react-app/yarn.lock.cached though? We only update that file when we do releases. Other than that I think it's ready to merge.

@krreet
Copy link
Contributor Author

krreet commented Sep 17, 2021

Hi @iansu
Reverted the changes in packages/create-react-app/yarn.lock.cached.
Now this should be ready to merge.

@raix
Copy link
Contributor

raix commented Sep 17, 2021

Not sure why we should need to check-in package-lock.json - feels wrong...

@iansu we do sometimes have to run the 'yarn compile:lockfile' for tests to pass

@iansu iansu added this to the 5.0 milestone Sep 22, 2021
@iansu iansu merged commit 63bba07 into facebook:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Jest 27 Ejecting causes Jest config to contain absolute paths
8 participants