Update @pmmmwh/react-refresh-webpack-plugin to 0.5.0-rc.3

[hasanayan]

there were some updates on @pmmmwh/react-refresh-webpack-plugin for webpack 5 and module federation compability. This PR upgrades the dependency to its last version.

Currently react-scripts is using @pmmmwh/[email protected], this seems to cause problems with module federation and those problems were fixed in the last version of the plugin. With this PR we aim to upgrade the dependency version to 0.5.0-rc.3 and resolve those issues.

#11241 (comment)

[raix]

@hasanayan the workbox fix is now on main, tests fail due to the broken workbox package

[raix]

@hasanayan try merging in main - I think we also need to update the compiled yarn lockfile as a dependency was updated 'yarn compile:lockfile'

[hasanayan]

@raix yarn.lock files seem to be ignored in this project. I merged main and now everything seem to be fine

[raix]

Super @hasanayan thanks!

Yeah the yarn.lock files are not checked in but we do generate a yarn.cached.lockfile in the create-react-app package - updated by running 'yarn compile:lockfile' (disclaimer I'm yet to figure out the reason behind it)

[hasanayan]

@raix here is the output I am getting from yarn compile:lockfile :( couldn't figure out the problem

yarn compile:lockfile
yarn run v1.22.11
$ node tasks/compile-lockfile.js
child_process.js:800
throw err;
^

<ref *1> Error: spawnSync yarn ENOENT
at Object.spawnSync (internal/child_process.js:1074:20)
at spawnSync (child_process.js:746:24)
at Object.execFileSync (child_process.js:792:15)
at Object. (C:\Users\esra6\hasan\create-react-app\tasks\compile-lockfile.js:33:12)
at Module._compile (internal/modules/cjs/loader.js:1072:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
at Module.load (internal/modules/cjs/loader.js:937:32)
at Function.Module._load (internal/modules/cjs/loader.js:778:12)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
at internal/main/run_main_module.js:17:47 {
errno: -4058,
code: 'ENOENT',
syscall: 'spawnSync yarn',
path: 'yarn',
spawnargs: [
'add',
'@babel/[email protected]',
'@pmmmwh/[email protected]',
'@svgr/[email protected]',
'babel-jest@^26.6.0',
'[email protected]',
'babel-plugin-named-asset-import@^0.3.7',
'babel-preset-react-app@^10.0.0',
'bfj@^7.0.2',
'browserslist@^4.16.6',
'camelcase@^6.2.0',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'eslint@^7.30.0',
'eslint-config-react-app@^6.0.0',
'eslint-webpack-plugin@^2.5.4',
'file-loader@^6.2.0',
'fs-extra@^10.0.0',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'react-app-polyfill@^2.0.0',
'react-dev-utils@^11.0.4',
'react-refresh@^0.10.0',
'[email protected]',
'resolve-url-loader@^4.0.0',
'sass-loader@^12.1.0',
'[email protected]',
'source-map-loader@^1.1.2',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]'
],
error: [Circular *1],
status: null,
signal: null,
output: null,
pid: 0,
stdout: null,
stderr: null
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[raix]

@hasanayan what version of node are you on?

[hasanayan]

@raix 14.17.5

[raix]

@hasanayan can't replicate 14.17.5 works fine for me

It's running the yarn add ... command so it seems like it's yarn exiting - what version of yarn are you on? Edit: (I'm on 1.22.5)
(could try yarn cache clean)

[hasanayan]

@raix my yarn version was 1.22.11 but I also tried your now and the result is the same. Anyway, I don't wanna bother you with this anymore. I am on my sister's laptop now and I hope my own machine will not have the same problem. Thanks for the support! 👊

[raix]

@hasanayan no worries - thanks again! :)

[hasanayan]

@hasanayan you are welcome. I am a CRA contributor now YAY!!!