Deprecate root level template.json keys #11188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansu
approved these changes
Jul 14, 2021
sumanthratna
pushed a commit
to sumanthratna/create-react-app
that referenced
this pull request
Aug 4, 2021
EhsanFortuna
pushed a commit
to EhsanFortuna/create-react-app
that referenced
this pull request
Aug 23, 2021
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
This was referenced May 21, 2024
This was referenced Sep 27, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates root-level
dependenciesandscriptskeys intemplate.json(see code). They now need to be nested under apackagekey.We've had a warning in place for this for a long time, and we made this change very early on so this shouldn't have any large impact.