-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run npm with --no-audit #11176
Merged
Run npm with --no-audit #11176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
July 3, 2021 16:51
sumanthratna
pushed a commit
to sumanthratna/create-react-app
that referenced
this pull request
Aug 4, 2021
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
This was referenced May 21, 2024
This was referenced May 23, 2024
This was referenced May 24, 2024
This was referenced Sep 27, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve the situation with #11174 somewhat.
These "audits" are pretty much always misleading for build tooling and get people into a hopeless rabbit hole of trying to work around issues that aren't real problems. Let's suppress the audit on the first run. The user can always do it themselves if they want to, but it's pretty much always misleading and harmful.