Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wp5 update webpack dependencies and fix minor issues #11170

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Wp5 update webpack dependencies and fix minor issues #11170

merged 4 commits into from
Jul 12, 2021

Conversation

raix
Copy link
Contributor

@raix raix commented Jul 1, 2021

This pull-request fixes minor issues in the wp5 branch and updates dependencies

  • Dependency update of Webpack 5 related dependencies
  • Removing the WatchMissingNodeModulesPlugin as it's not working in Webpack 5 when caching is enabled (triggering recompilations)
  • Remove unused pnpTs file - Support for pnp is builtin to webpack 5 and forkTypescriptChecker
  • Fix babel warning after dependency update - @babel/plugin-proposal-private-methods was being used in the background (now explicite dependency) and required loose to be set true / same as @babel/plugin-proposal-class-properties

Fixes #11169

Related to #9994

Morten N.O. Nørgaard Henriksen added 4 commits July 1, 2021 22:37
Removing the WatchMissingNodeModulesPlugin as it's not working in Webpack 5 when caching is enabled
Support for pnp is builtin to webpack 5 and forkTypescriptChecker
`@babel/plugin-proposal-private-methods` was being used in the background (now explicite dependency) and required loose to be set true / same as `@babel/plugin-proposal-class-properties`
@mrmckeb
Copy link
Contributor

mrmckeb commented Jul 2, 2021

With WatchMissingNodeModulesPlugin removed, this is possibly already a breaking change. So I think we'd have to ship this as a major, which is also good because we might break compatibility with tools like Craco with this release too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants