Bumped postcss-normalize to v10

[Bluefitdev]

[email protected] was released with support for PostCSS 8

We should bump it after merging #10456

[facebook-github-bot]

Hi @Bluefitdev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[DrogoNevets]

@Bluefitdev are you aware your PR doesnt build?
only asking as our build step has an audit dependency check in it, and is currently failing due to postcss

[Bluefitdev]

Yeah @DrogoNevets , Node 10 is not supported anymore from postcss 8 postcss-normalize.. But i'm not sure what happened for some node12 eject test. Have to test more sorry

Edit: Clarified by @camjackson that actually postcss-normalize v10 requires node 12

[DrogoNevets]

In our pipeline, i think its complaining about a new instance needing the new keyword, so I am guessing theyve made something a class, that wasnt originally

[camjackson]

Actually I think postcss 8 itself supports node v10 just fine: https://github.com/postcss/postcss/blob/main/package.json#L6

It's postcss-normalize 10 that requires node 12+: https://github.com/csstools/postcss-normalize/blob/main/CHANGELOG.md#1000-april-28-2021

Is that going to be a blocker? The CRA docs say "You’ll need to have Node >= 10", but is there any scope to bump that up to v12? It seems like we can't get postcss 8 into react-scripts without doing so.

For reference, node v12 came out a little over 2 years ago.

[Bluefitdev]

FYI, after inspecting, most test fails on node 12 because of this:

FAIL fixtures/mjs-support/index.test.js (658.57 s)
  ● can use mjs library in development

    : Timeout - Async callback was not invoked within the 300000 ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 300000 ms timeout specified by jest.setTimeout.Error:

      3 | const puppeteer = require('puppeteer');
      4 |
    > 5 | test('can use mjs library in development', async () => {
        | ^
      6 |   const { port, done } = await testSetup.scripts.start();
      7 |
      8 |   const browser = await puppeteer.launch({ headless: true });

      at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Object.<anonymous> (fixtures/mjs-support/index.test.js:5:1)

  ● can use mjs library in production

    : Timeout - Async callback was not invoked within the 300000 ms timeout specified by jest.setTimeout.Timeout - Async callback was not invoked within the 300000 ms timeout specified by jest.setTimeout.Error:

      21 |   }
      22 | });
    > 23 | test('can use mjs library in production', async () => {
         | ^
      24 |   await testSetup.scripts.build();
      25 |   const { port, done } = await testSetup.scripts.serve();
      26 |

      at new Spec (../node_modules/jest-jasmine2/build/jasmine/Spec.js:116:22)
      at Object.<anonymous> (fixtures/mjs-support/index.test.js:23:1)

A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks.
Snapshot Summary
 › 4 snapshots failed from 1 test suite. Inspect your code changes or re-run jest with `-u` to update them.

Test Suites: 5 failed, 7 passed, 12 total
Tests:       11 failed, 22 passed, 33 total
Snapshots:   4 failed, 6 passed, 10 total
Time:        695.165 s
Ran all test suites.
++ set +x
e2e-behavior.sh: ERROR! An error was encountered executing line 88.
Cleaning up.
yarn config v1.22.5
success Set "registry" to "https://registry.yarnpkg.com".
Done in 0.04s.
Exiting with error.
The STDIO streams did not close within 10 seconds of the exit event from process '/bin/bash'. This may indicate a child process inherited the STDIO streams and has not yet exited.
##[error]Bash exited with code '1'.
Finishing: Run tests

[raix]

@Bluefitdev maybe we should remove the LinuxNode10 entry in the azure-pipelines-test-job.yml?
Edit: In general the test suite is broken and we should likely either fix it or skip the failing tests for now... (Last merged pull-requests only had "kitchensink"+"Simple"+"OldNode" tests passing)

[Bluefitdev]

Can I remove the Node10 from pipeline in azure-pipelines.yml ? Would that okay from CRA team?

  - template: azure-pipelines-test-job.yml
    parameters:
      name: Behavior
      testScript: tasks/e2e-behavior.sh
      configurations:
        LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
        LinuxNode12: { vmImage: 'ubuntu-16.04', nodeVersion: 12.x }
        WindowsNode10: { vmImage: 'windows-2019', nodeVersion: 10.x }
        WindowsNode12: { vmImage: 'windows-2019', nodeVersion: 12.x }
        MacNode10: { vmImage: 'macOS-10.15', nodeVersion: 10.x }
        MacNode12: { vmImage: 'macOS-10.15', nodeVersion: 12.x }

Edit: Removed node 10, lets see if the behaviour test works this time

[raix]

Only kitchensink/simple/oldnode are passing - the rest of the tests have been broken for a while.

[raix]

A small pr that hopefully fixes the postcss 8 update

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[derrabus]

Dear Mr. bot, please don't close this PR.

[robertwt7]

We need release please

[mrmckeb]

For reference, we still support Node 10, and this PR breaks Node 10 support which is why we haven't merged, yet. We're hoping to get this out soon though.

[raix]

Ref: csstools/postcss-normalize#56

[tim-phillips]

postcss-normalize is at v10. Can this PR be closed?

create-react-app/packages/react-scripts/package.json

Line 61 in 749a76d

"postcss-normalize": "10.0.0",

https://github.com/facebook/create-react-app/blob/main/packages/react-scripts/package.json

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.