Remove outdated comments on react-refresh #10784
Conversation
cdtkrk
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @kidkkr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Hi @kidkkr, the FAST_REFRESH support is stable, but the comment has not been updated (it was merged as experimental in #8582 and rolled out as stable in 4.0.0.). The comment should be removed or updated accordingly. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Okay, @petetnt ! Would you mind if I remove comments in this PR instead? |
cdtkrk
changed the title
Related Issue: #9984
EDITED:
See #10784 (comment)
Without
FAST_REFRESH=false, auto reload onsrc/index.jsdoes not work.According to comment,
react-refreshshould be disabled by default.This commit changes default value of
process.env.FAST_REFRESH.For testing
$ yarn create-react-app path/to/app.Edit
path/to/app/src/index.js.