Remove bundledDependencies #1068
Conversation
fson
commented
Nov 20, 2016
fson
commented
- Remove bundledDependencies
- Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
* Remove bundledDependencies * Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
|
|
||
| # This modifies package.json to copy all dependencies to bundledDependencies | ||
| node ./node_modules/.bin/bundle-deps | ||
|
|
There was a problem hiding this comment.
Can you explain why bundle-deps was removed?
There was a problem hiding this comment.
Because of many issues with them due to npm's buggy client implementation.
There was a problem hiding this comment.
Curiously, the bundled dependencies weren't really speeding up the installation either. I did a quick benchmark comparing the latest nightly build (without bundled deps) and 0.7.0 and there was no discernible difference in the time to create a new app. With a warmed up cache, the new version without bundled deps was actually outperforming the old version that had them.
There was a problem hiding this comment.
Maybe it was only true for earlier versions with a different dependency structure or something like this.
|
If Travis passes lgtm. |
* Remove bundledDependencies * Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
Disabled because npm/npm#12834 It will also be removed upstream soon: facebook#1068
* Remove bundledDependencies * Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
Bundled dependencies is having some weird structure on npm client implementation, so removing it to work seamsless with npm and yarn
* Remove bundledDependencies * Change the e2e scripts to use local file dependencies instead of bundledDependencies to test the packages
