Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing dev argument in build script message #1058

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Add missing dev argument in build script message #1058

merged 1 commit into from
Nov 20, 2016

Conversation

nhajidin
Copy link
Contributor

Add --dev argument to the yarn add gh-pages message to match the npm one.

@fson fson added this to the 0.8.0 milestone Nov 20, 2016
@fson fson merged commit 1668fb1 into facebook:master Nov 20, 2016
@fson
Copy link
Contributor

fson commented Nov 20, 2016

Thanks!

@nhajidin nhajidin deleted the fix-build-script branch November 20, 2016 20:33
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
@nhajidin @jarlef
Add missing --dev argument (facebook#1058)
2e9da1b
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
@nhajidin @alexdriaguine
Add missing --dev argument (facebook#1058)
bbcf139
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@nhajidin @randycoulman
Add missing --dev argument (facebook#1058)
c10ae2f
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nhajidin @fson @facebook-github-bot