Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't strip stack traces of evaluated webpack bundles #1050

Merged
merged 4 commits into from
Dec 5, 2016
Merged

Don't strip stack traces of evaluated webpack bundles #1050

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67d923e
Don't strip stack traces of evaluated webpack code
jameslnewell Nov 17, 2016
8191ca8
Strip stack traces at the end of a string
jameslnewell Nov 17, 2016
632a92a
code comment
Nov 21, 2016
d6c76f4
code comment
Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-dev-utils/formatWebpackMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,12 @@ function formatMessage(message) {

// Reassemble the message.
message = lines.join('\n');
// Internal stacks are generally useless so we strip them
// Internal stacks are generally useless so we strip them... with the
// exception of stacks containing `webpack:` because they're normally
// from user code generated by WebPack. For more information see
// https://github.com/facebookincubator/create-react-app/pull/1050
message = message.replace(
/^\s*at\s.*:\d+:\d+[\s\)]*\n/gm, ''
/^\s*at\s((?!webpack:).)*:\d+:\d+[\s\)]*(\n|$)/gm, ''
); // at ... ...:x:y

return message;
Expand Down