Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running ESLint #136

Closed
kevinastone opened this issue Jul 23, 2016 · 1 comment
Closed

Running ESLint #136

kevinastone opened this issue Jul 23, 2016 · 1 comment

Comments

@kevinastone
Copy link

Similar to #124, what's the expected way to run eslint? Should there be a npm run lint?

I got it to run with the included config, but I can't imagine most users would find this:

./node_modules/react-scripts/node_modules/.bin/eslint -c ./node_modules/react-scripts/config/eslint.js src
@mxstbr
Copy link
Contributor

mxstbr commented Jul 23, 2016

eslint is ran with the eslint-loader, i.e. you'll get errors and warnings in your console while npm start is running.

For further discussions about moving this out for IDE support etc. see #124!

@mxstbr mxstbr closed this as completed Jul 23, 2016
grengojbo pushed a commit to grengojbo/es6-react-scripts that referenced this issue Jun 6, 2018
@kitze
Merge pull request facebook#136 from Jorer/fix-jest-snapshot-css-modules
a376a94 
Fix Jest snapshot CSS Module class names, add CSS Module class name template as a configuration option. Closes facebook#106 and facebook#97.
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinastone @mxstbr