Leak the global static mutex in CKTextKitContext to avoid static destructor fiasco #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor fiasco I haven't tested this code, but this is what I would try to resolve facebook#892. Someone should run some smoke tests with something like the above
|
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
gkassabli
approved these changes
Apr 12, 2018
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
@gkassabli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
chuganzy
added a commit
to chuganzy/react-native
that referenced
this pull request
Dec 11, 2018
chuganzy
added a commit
to chuganzy/react-native
that referenced
this pull request
Dec 11, 2018
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Feb 14, 2019
Summary: Try to solve #13588 ref: facebook/componentkit#906 Pull Request resolved: #22607 Differential Revision: D14084056 Pulled By: shergin fbshipit-source-id: 585aef758e1a215e825ae12914c5011d790a69b0
JAStanton
pushed a commit
to convoyinc/react-native
that referenced
this pull request
Feb 19, 2019
Summary: Try to solve facebook#13588 ref: facebook/componentkit#906 Pull Request resolved: facebook#22607 Differential Revision: D14084056 Pulled By: shergin fbshipit-source-id: 585aef758e1a215e825ae12914c5011d790a69b0
JAStanton
pushed a commit
to convoyinc/react-native
that referenced
this pull request
Feb 19, 2019
Summary: Try to solve facebook#13588 ref: facebook/componentkit#906 Pull Request resolved: facebook#22607 Differential Revision: D14084056 Pulled By: shergin fbshipit-source-id: 585aef758e1a215e825ae12914c5011d790a69b0
JAStanton
pushed a commit
to convoyinc/react-native
that referenced
this pull request
Feb 19, 2019
Summary: Try to solve facebook#13588 ref: facebook/componentkit#906 Pull Request resolved: facebook#22607 Differential Revision: D14084056 Pulled By: shergin fbshipit-source-id: 585aef758e1a215e825ae12914c5011d790a69b0
JAStanton
pushed a commit
to convoyinc/react-native
that referenced
this pull request
Feb 19, 2019
Summary: Try to solve facebook#13588 ref: facebook/componentkit#906 Pull Request resolved: facebook#22607 Differential Revision: D14084056 Pulled By: shergin fbshipit-source-id: 585aef758e1a215e825ae12914c5011d790a69b0
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 28, 2021
Summary: This intentionally leaks the static map, since it still might be accessed after static destructors are run. This is a common approach to this problem, see #22607 and facebook/componentkit#906 as examples. It also sets up an autorelease pool from `RCTNativeModule::invoke` as a precaution since there's no strict guarantee one exists when it is called. Changelog: [iOS][Fixed] - Fix crash in RCTCoreModulesClassProvider during quit Reviewed By: RSNara Differential Revision: D27932062 fbshipit-source-id: fa75da4b78290027a762440ac6943c81b8594a57
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this code, but this is what I would try to resolve #892. Someone should run some smoke tests with something like the above