pep8; removed unused vars #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the pull request! Was this done using a tool? Could you update the pull request to leave out all the indentation, whitespace, and line wrapping changes? It would be great to remove unused vars, but I'd rather avoid reformatting the entire code base. |
Contributor
Author
|
I changed my commit. I left out style conventions and removed unused imports, vars and fixed a couple of minor issues. I generally use PyCharm to identify issues like that. |
commands/FBFlickerCommands.py
Outdated
Contributor
There was a problem hiding this comment.
This block shouldn't be removed. recursionName is used below.
Contributor
Author
|
Readded 👍 |
Contributor
|
Thanks again for the pull request! |
Contributor
Author
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.