Don't skip prologue for bmessage breakpoints
#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The x86 expression returned from `functionPreambleExpressionForSelf()` expects the breakpoint to be stopped before the prologue.
Contributor
Author
|
@mattjgalloway Thoughts on this? |
Contributor
|
@kastiglione LGTM. Ship it! |
kastiglione
added a commit
that referenced
this pull request
May 1, 2015
Don't skip prologue for `bmessage` breakpoints
Contributor
Author
|
👌 thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The x86 expression returned from
functionPreambleExpressionForSelf()expects the breakpoint to be stopped before the prologue. The other architectures should work before or after prologue.Resolves #89