Skip to content

Fixed incorrect usage of global foundElement causing crashes in some searches #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kastiglione merged 2 commits into from
Feb 21, 2015
Merged

Fixed incorrect usage of global foundElement causing crashes in some searches #76

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be66908
Fixed incorrect usage of global foundElement causing crashes in some …
Feb 20, 2015
8cbfd4b
Refactored fa11y to not use global variables
Feb 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions commands/FBAccessibilityCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def printAccessibilityHierarchy(view, indent = 0):
print indentString + ('({} {}) {}'.format(classDesc, view, a11yLabel.GetObjectDescription()))

def accessibilityGrepHierarchy(view, needle):
global foundElement

@kastiglione kastiglione Feb 20, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these methods be made instance methods, and then foundElement made into an attribute? Or does this value need to persist from one chisel command invocation to the next?

a11yLabel = accessibilityLabel(view)

#if we don't have any accessibility string - we should have some children
Expand Down