Skip to content

add ppath command #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kastiglione merged 7 commits into from
Mar 28, 2015
Merged

add ppath command #72

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72145be
add ppath command
Jan 14, 2015
ff0d763
change command name
Jan 15, 2015
e6e9f51
option -o "open in finder"
Jan 28, 2015
aa3396f
Merge branch 'master' of https://github.com/facebook/chisel
Mar 17, 2015
f3119a6
refactor pdocspath
Mar 17, 2015
84d60b8
copy to the pasteboard before print
Mar 27, 2015
8f16c09
resolve conflict
Mar 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions commands/FBPrintCommands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def lldbcommands():
FBPrintInternals(),
FBPrintInstanceVariable(),
FBPrintKeyPath(),
FBPrintApplicationDocumentsPath(),
]

class FBPrintViewHierarchyCommand(fb.FBCommand):
Expand Down Expand Up @@ -299,3 +300,27 @@ def run(self, arguments, options):
object = fb.evaluateObjectExpression(objectToMessage)
printCommand = 'po [{} valueForKeyPath:@"{}"]'.format(object, keypath)
lldb.debugger.HandleCommand(printCommand)


class FBPrintApplicationDocumentsPath(fb.FBCommand):
def name(self):
return 'pdocspath'

def description(self):
return "Print application's 'Documents' directory path."

def options(self):
return [
fb.FBCommandArgument(short='-o', long='--open', arg='open', boolean=True, default=False, help='open in Finder'),

@kastiglione kastiglione Feb 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

]

def run(self, arguments, options):
if options.open:
path = fb.evaluateExpressionValue('(NSString *)[NSSearchPathForDirectoriesInDomains(9, 1, YES) lastObject]')

@kastiglione kastiglione Feb 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make constants for these numbers?

@kastiglione kastiglione Feb 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use evaluateObjectExpression() instead of evaluateExpressionValue(), which would make the NSString cast unnecessary.

@dopcn dopcn Mar 17, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kastiglione hi I tried evaluateObjectExpression() and evaluateExpression() but only get pointer value instead of string value so I keep using evaluateExpressionValue() and split the string output in the new implementation. Am I missing something?

pathString = '{}'.format(path).split('"')[1]
print pathString
lldb.debugger.HandleCommand('script os.system("open {}")'.format(pathString))

@kastiglione kastiglione Feb 7, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can call os.system() directly, it's not necessary to call it via HandleCommand().

else:
lldb.debugger.HandleCommand('po [NSSearchPathForDirectoriesInDomains(9, 1, YES) lastObject]') # NSDocumentDirectory == 9 NSUserDomainMask == 1