support x86_64h

[samanthamjohn]

Using OSX Yosemite 10.10.2 and Xcode Version 6.1.1 (6A2008a) my architecture comes up as x86_64h. This leads to the error: Your architecture, {}, is truly fantastic. However, I don\'t currently support it.

Adding x86_64h as an option to this file allows chisel to work properly.

[kastiglione]

Thanks @Samjohn ⭐

Would you mind signing Facebook's Contributor License Agreement? If you have any questions I'd be happy to help answer. https://code.facebook.com/cla

[samanthamjohn]

done

[kastiglione]

Instead of checking for variations at these call sites, would you mind doing a normalization inside currentArch(). In other words, make currentArch() return 'x86_64' instead of 'x86_64h'. Thoughts?

[samanthamjohn]

yeah, I can do that. I wasn't sure if there were any significant differences between x86_64 and x86_64h that would need to be addressed elsewhere in the code. This fix works for bmessage but I haven't tried out all the functionality in the repo so it may still break in other places.

[kastiglione]

Thanks. As of now, any differences between the two don't matter to Chisel. This pull request will fix bmessage and taplog. If we ever need to differentiate, we can figure out the best approach then.

[kastiglione]

🚢

[kastiglione]

Thanks again!