Added 'slow' command. #67
Conversation
|
Thank you @bartoszj 👍 Would you mind signing Facebook's Contributor License Agreement? If you have any questions I'd be happy to help answer. https://code.facebook.com/cla |
|
Done. |
commands/FBDisplayCommands.py
Outdated
There was a problem hiding this comment.
What do you think about calling this slowanim?
|
@bartoszj Thanks for submitting this! I have a couple comments above. What do you think about adding two commands, one to turn this on, one to turn if off. All of our other commands work this way, so we should be consistent unless there's a good reason not to be. If we have two commands, they can both have a default speed, with the undo command having a speed of 1. |
|
Isn't this the same as 'slowanim' and 'unslowanim' or have we not merged that, @kastiglione ? |
|
@kastiglione I agree with two commands. |
|
Great! 🙇 |
* commit 'abcbb93abe22d98b273c981c71c96ece80286af6': Reverting some of the code review changes Code cleanup Review corrections Added print accessibility tree command. Find accessibility element command reworked Add basic Swift support (requires Xcode 6)
|
Updated. |
fblldbviewhelpers.py
Outdated
There was a problem hiding this comment.
This is awesome!
For what it's worth, another way that might have worked is to use NSArray's custom implementation of -setValue:forKey::
[[[UIApplication sharedApplication] windows] setValue:@(speed) forKey:@"speed"]There was a problem hiding this comment.
Where allowable, can we change the XYClass * casts to simply id?
|
Thanks @bartoszj! I left a couple comments, the main one is about giving |
|
I've found that iOS Simulator is using 0.1 as speed value and I've set it in the |
|
💥 Looks good. I'll checkout this branch and give it a try and merge if all goes well. Thanks! |
|
Thanks for this contribution! And thanks for being patient and awesome 👍 |
3 participants
This command slows down animations. Works like 'Toggle Slow Animations' from iOS Simulator but this command works also on the device and user is able to select animation speed.