Added FBPrintWindow command #239
Conversation
|
Thanks Pete. I like it. I have some thoughts. This is the same as |
|
@PeteTheHeat what do you think about my suggestion? |
|
Yeah that makes sense! Let me update it. |
| if arguments[0] == '__keyWindow_dynamic__': | ||
| arguments[0] = '(id)[[UIApplication sharedApplication] keyWindow]' | ||
|
|
||
| if window > 0: |
There was a problem hiding this comment.
It looks like this check can be removed.
There was a problem hiding this comment.
I see now why you have this. Never mind :)
There was a problem hiding this comment.
Yup I was hoping the if/else flow was clear, if a window is passed in, do some new stuff, else fall back to what the code was doing before.
commands/FBPrintCommands.py
Outdated
| @@ -20,6 +20,7 @@ | |||
| def lldbcommands(): | |||
| return [ | |||
| FBPrintViewHierarchyCommand(), | |||
| FBPrintWindow(), | |||
There was a problem hiding this comment.
Now that pviews supports -w, I don't think it's worth having a separate command. A user could get pwindow by adding this to their ~/.lldbinit:
command alias pwindow pviews --window %1
There was a problem hiding this comment.
Yup, I tried to delete it but it came back in the merge somehow lol, I'm too used to hg these days. I'll remove it
|
thanks! |
I've been working with input accessory views quite a bit. They've been annoying to debug because they don't live in the main key window, they are hosted in the Keyboard's window. I added a short chisel command locally to make printing a window easy. Let me know if this is something useful for the library.